Refactor SquinToStimPass for clifford dialect + performance #510
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…code as unit test
☂️ Python Coverage
Overall Coverage
New Files
Modified Files
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
johnzl-777
changed the title
johnzl-777
force-pushed
the
john/squin-to-stim-performance-refactor
branch
from
9b63bee to
9d86c00
Compare
…ime tests happy and drop wire reset test
johnzl-777
force-pushed
the
john/squin-to-stim-performance-refactor
branch
from
2fd6109 to
275ea82
Compare
david-pl
reviewed
Oct 13, 2025
david-pl
reviewed
Oct 14, 2025
|
|
||
|
|
||
| @statement(dialect=dialect) | ||
| class Reset(ir.Statement): |
There was a problem hiding this comment.
This statement needs a pyqrack method and a cirq emit method impl. I can also add those, if you like. So either add them here, or a create a new issue and assign it to me, please.
There was a problem hiding this comment.
I'll make an issue, thank you! (See #546 )
rafaelha
reviewed
Oct 14, 2025
This was referenced Oct 14, 2025
… instead of assertion-based failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also included a repetition code - like unit test. I figure this would be nice to have first before working on #498
I believe this should be backportable too which would be great because I'd like to use the
flattenpass elsewhere instead of having identical versions floating around (: